Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix div 0 error of case11: paddle.nn.functional.max_pool1d/max_pool2d/max_pool3d #50010

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Fix div 0 error of case11: paddle.nn.functional.max_pool1d/max_pool2d/max_pool3d #50010

merged 2 commits into from
Feb 1, 2023

Conversation

RedContritio
Copy link
Contributor

PR types

Bug fixes

PR changes

OPs

Describe

Solution

  • 限制 stride != 0

@paddle-bot
Copy link

paddle-bot bot commented Jan 22, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Jan 22, 2023
@Ligoml Ligoml mentioned this pull request Jan 23, 2023
Closed
wanghuancoder
wanghuancoder reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为这个case加个单测吧

@RedContritio
Copy link
Contributor Author

为这个case加个单测吧

已添加

wanghuancoder
wanghuancoder approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

weisy11
weisy11 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@weisy11 weisy11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 3ab6faa into PaddlePaddle:develop Feb 1, 2023
pangengzheng pushed a commit to pangengzheng/Paddle that referenced this pull request Feb 2, 2023
@RedContritio @pangengzheng
Fix div 0 error of case11: paddle.nn.functional.max_pool1d/max_pool2d…
45a1b06 
…/max_pool3d (PaddlePaddle#50010)

* add stride check for MaxPool

* add unittests
@RedContritio RedContritio deleted the maxpool_stride branch February 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanghuancoder wanghuancoder wanghuancoder approved these changes

@weisy11 weisy11 weisy11 approved these changes

Assignees

@luotao1 luotao1

@weisy11 weisy11

@wanghuancoder wanghuancoder

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedContritio @weisy11 @wanghuancoder @luotao1