Fix lu_factor_ex #268
Closed
Fix lu_factor_ex #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
This was referenced Sep 4, 2023
Merged
zhwesky2010
reviewed
Sep 5, 2023
| API_TEMPLATE = textwrap.dedent( | ||
| """ | ||
| out1, out2, out3 = {}({}) | ||
| out3 = paddle.to_tensor(out3.item(), dtype='int32') |
There was a problem hiding this comment.
这个功能 只是做一个cast为int32的类型变化吗
zhwesky2010
reviewed
Sep 6, 2023
| @@ -37,7 +36,6 @@ def test_case_2(): | |||
| import torch | |||
| x = torch.tensor([[1.0, 2.0], [3.0, 4.0], [5.0, 6.0]], dtype=torch.float64) | |||
| LU, pivots, info = torch.linalg.lu_factor_ex(A=x) | |||
| info = info.item() | |||
| """ | |||
| ) | |||
| obj.run(pytorch_code, ["LU", "pivots", "info"]) | |||
There was a problem hiding this comment.
这个只有一个shape的差异吗，先设置 check_shape=False 来测试吧，这个问题我们会在框架上修复，shape=[]的0D更合理
There was a problem hiding this comment.
https://github.com/PaddlePaddle/PaConvert/blob/master/tests/apibase.py
参数不包括 check_shape
There was a problem hiding this comment.
好吧，那暂时就先这样转吧，文档中说明下就可以，等修复0D这个问题后再删掉 info.item() 这行就可以
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Docs
#256
info.item()转写修改
文档修改 PaddlePaddle/docs#6160
PR APIs