-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sbgECom driver documentation #3529
base: main
Are you sure you want to change the base?
Conversation
No flaws found |
@@ -1,7 +1,65 @@ | |||
# Modules Reference: Ins (Driver) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs need to be included in your driver source code, and then will automatically be generated - for example see https://docs.px4.io/main/en/modules/modules_driver_ins.html - the vectornav docs are created from this source: https://github.com/PX4/PX4-Autopilot/blob/main/src/drivers/ins/vectornav/VectorNav.cpp#L828
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I.e. please remove this for now.
@@ -30048,6 +30048,42 @@ Reboot | minValue | maxValue | increment | default | unit | |||
--- | --- | --- | --- | --- | --- | |||
✓ | | | | 500000 | | |||
|
|||
### SBG_BAUDRATE (`INT32`) {#SBG_BAUDRATE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter docs are autogenerated from source. So when your driver PR is merged you'll get this stuff appearing automatically. Please remove this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I see that at least some of these are already defined.
|
||
[SBG-Systems](https://www.sbg-systems.com/) designs, manufactures, and support an extensive range of state-of-the-art inertial sensors such as Inertial Measurement Units (IMU), Attitude and Heading Reference Systems (AHRS), Inertial Navigation Systems with embedded GNSS (INS/GNSS) … | ||
|
||
![Ellipse](../../assets/hardware/sensors/inertial/ellipse-inertial-navigation-system.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Can you run prettier on this markdown file please. Your repo is rejecting my fixes.
- Can you crop the whitespace above and below the image.
Even better, give me edit rights over this repo and I can push the fixes myself.
|
No description provided.