Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style drag n drop #804

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Style drag n drop #804

merged 2 commits into from
Aug 22, 2023

Conversation

brandonhundt
Copy link
Contributor

Closes: #768

  • This is a NO JS approach. It does most things except hover on the drop (which I think is okay.) If folks feel that is important we can add.

@@ -112,6 +112,10 @@ label[required="true"] {
border-color: $red;
}

&.prx_dragndrop {
border: 2px dashed $gray-300;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a custom class to apply to file fields - I had to do this to overwrite the form-control border

@@ -545,7 +545,7 @@ en:
sample_rate: Frequency
status: Status
new:
hint: Upload a file
hint: Upload a file or drag it here
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figure some language to indicate drag n drop is available might be enough in and of itself.

Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brandonhundt brandonhundt merged commit f3345ba into main Aug 22, 2023
1 check passed
@farski farski deleted the feat/768-style-drag-n-drop branch June 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style drag-n-drop uploaders
2 participants