Fix: no delivery files are expected if there is no delivery #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a case where an episode was uploaded to the apple system, but the wait for linked asset state timed out.
Upon manual retry, the episode was marked for re-upload by deleting the delivery/delivery_files on the episode (
PodcastContainer#reset_source_file_metadata). But since the creation of delivery files changed with 520f2c9 (now based on Episode#needs_delivery?), the guard in the Apple::PodcastDeliveryFile class was blowing up -- expecting a delivery to be inplace.This PR removes the assumption that a Apple::PodcastDelivery has to be in place in the delivery file sync routine. If the file is in the container, there is no need to redeliver -- in this case the episode simply needed to be marked as published.