Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move itunes categories to Feed #751

Merged
merged 10 commits into from
Aug 14, 2023
Merged

Move itunes categories to Feed #751

merged 10 commits into from
Aug 14, 2023

Conversation

cavis
Copy link
Member

@cavis cavis commented Aug 9, 2023 •
edited
Loading

FIxes #701. NOTE TO SELF: you should really QA this vs Publish Staging before going to prod. Just in case I broke the API (I don't think I did).

  • Moves the has_many :itunes_categories from the Podcast to the Feed.
  • Adds some shims/delegators on the Podcast to keep things working in the API
  • Rewire the Podcast Settings form a bit to make this continue to work
  • Add optional overrides to the Feed form

image

@cavis cavis self-assigned this Aug 9, 2023
cavis
cavis commented Aug 9, 2023
View reviewed changes
app/models/feed.rb Show resolved Hide resolved
app/views/feeds/_form_overrides.html.erb Show resolved Hide resolved
app/views/podcasts/_form_main.html.erb Show resolved Hide resolved
app/models/podcast.rb Show resolved Hide resolved
radical-ube
radical-ube approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@radical-ube radical-ube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@cavis cavis merged commit 62e02b4 into main Aug 14, 2023
1 check passed
@cavis cavis deleted the feat/per_feed_itunes_cats branch August 14, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radical-ube radical-ube radical-ube approved these changes

Assignees

@cavis cavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Per-Feed itunes category
2 participants
@cavis @radical-ube