Don't alter data unless needed

app/models/apple/show.rb

@@ -63,21 +63,32 @@ def category_data
       [{"type" => "categories", "id" => "1301"}]
     end
 
-    def show_data
+    def update_attributes
+      create_attributes.except(:releaseFrequency)
+    end
+
+    def create_attributes
       {
-        data: {
-          type: "shows",
-          relationships: {
-            allowedCountriesAndRegions: {data: api.countries_and_regions}
-          },
-          attributes: {
-            kind: "RSS",
-            rssUrl: feed_published_url,
-            releaseFrequency: "OPTOUT",
-            thirdPartyRights: "HAS_RIGHTS_TO_THIRD_PARTY_CONTENT"
+        kind: "RSS",
+        rssUrl: feed_published_url,
+        releaseFrequency: "WEEKLY",
+        thirdPartyRights: "HAS_RIGHTS_TO_THIRD_PARTY_CONTENT"
+      }
+    end
+
+    def show_data(attributes, id: nil)
+      res =
+        {
+          data: {
+            type: "shows",
+            relationships: {
+              allowedCountriesAndRegions: {data: api.countries_and_regions}
+            },
+            attributes: attributes
           }
         }
-      }
+      res[:data][:id] = id if id.present?
+      res
     end
 
     def apple_id
@@ -106,20 +117,23 @@ def sync!
     end
 
     def create_show!
-      data = show_data
+      data = show_data(create_attributes)
       Rails.logger.info("Creating show", show_data: data)
       resp = api.post("shows", data)
 
       api.response(resp)
     end
 
     def update_show!(sync)
-      show_data_with_id = show_data
-      show_data_with_id[:data][:id] = sync.external_id
-      Rails.logger.info("Updating show", show_data: show_data_with_id)
-      resp = api.patch("shows/#{sync.external_id}", show_data_with_id)
-
-      api.response(resp)
+      Rails.logger.warn("Skipping update for existing show!")
+      nil
+
+      # TODO, map out the cases where we'd actually need to update a show
+      # data = show_data(update_attributes, id: apple_id)
+      # Rails.logger.info("Updating show", show_data: data)
+      # resp = api.patch("shows/#{sync.external_id}", data)
+      #
+      # api.response(resp)
     end
 
     def create_or_update_show(sync)

test/models/apple/show_test.rb

@@ -161,7 +161,7 @@
 
   describe "#show_data" do
     it "returns a hash" do
-      assert_equal apple_show.show_data.class, Hash
+      assert_equal apple_show.show_data({}).class, Hash
     end
   end