Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Episode media tab #732

Merged
merged 27 commits into from
Aug 9, 2023
Merged

Episode media tab #732

merged 27 commits into from
Aug 9, 2023

Conversation

cavis
Copy link
Member

@cavis cavis commented Jul 31, 2023 •
edited
Loading

Moves Episode -> Settings media uploader and Episode -> Segmenter to a new tab all its own.

Bit of rewiring to make things work again, but not much actual code change.

cavis and others added 22 commits July 31, 2023 13:47
@cavis
Stub in episode media tab
bfa43a7
@cavis
Merge branch 'main' into feat/episode_media_tab
abd2052
@cavis
Relocate episode media
c60fa6a
@cavis
Fix some references
678331a
@cavis
Fix translations
b6d2b92
@cavis
Minor fixup on retrying/copying
a7edb85
@cavis
Move medium/segment_count outside of card
85f9d88
@cavis
Init segmenter card
aa930e7
@cavis
Default segment count, from the UI only
1dd793d
@cavis
Reorder null dropdates to the top
7ebebac
@cavis
Reorganize, so segmenter is full width
96307cb
@cavis
Add the actual segments field
a3fc5ac
@brandonhundt
feat(episode_media): provide audio status labels
38667b9
@brandonhundt
feat(episode_media): Truncate title
db1f528
@brandonhundt
lint
e6746d2
@cavis
Slice uncut after save
a714b6b
@cavis
Remove segmenter tab
03d5724
@cavis
Wire up badges; more uncut-media debugging
bea448e
@cavis
Cut from final url, not original (temp upload) url
79b14c4
@cavis
Episode media status indicator
1d23d80
@cavis
Add media status to episode index
68dd587
@cavis
Fix title overflow
2246628
@cavis cavis marked this pull request as ready for review August 8, 2023 21:03
@cavis cavis requested a review from brandonhundt August 8, 2023 21:06
@cavis cavis self-assigned this Aug 8, 2023
brandonhundt
brandonhundt approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@brandonhundt brandonhundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well in my functional tests. I think this will improve the UI and UX. thanks!

@cavis cavis merged commit 118bba7 into main Aug 9, 2023
1 check passed
@cavis cavis deleted the feat/episode_media_tab branch August 9, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonhundt brandonhundt brandonhundt approved these changes

Assignees

@cavis cavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cavis @brandonhundt