Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non sticky modals #718

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Non sticky modals #718

merged 3 commits into from
Jul 25, 2023

Conversation

cavis
Copy link
Member

@cavis cavis commented Jul 25, 2023

No description provided.

brandonhundt
brandonhundt approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@brandonhundt brandonhundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the assist! Much cleaner.

@brandonhundt brandonhundt mentioned this pull request Jul 25, 2023
Closed
@cavis cavis merged commit 16afc18 into main Jul 25, 2023
1 check passed
@cavis cavis deleted the fix/non-sticky-modals branch July 25, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonhundt brandonhundt brandonhundt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cavis @brandonhundt