Apple retry uploads #707
Apple retry uploads #707
Conversation
|
|
||
| # We don't get back the full episode model in the response. | ||
| # So poll for current state | ||
| poll_episode_state(api, show, episodes) |
There was a problem hiding this comment.
Tracking a few of these: There was a remote state transition, but the local data was not updated to reflect that. So make sure the local data is up to date.
| podcast_delivery_files.all?(&:processed?) && | ||
| !podcast_delivery_files.all?(&:processed_errors?) && | ||
| !audio_asset_state_finished?) | ||
| podcast_container.delivery_settled? && !audio_asset_state_finished? |
There was a problem hiding this comment.
so now only looking the episode's audio_asset_state and at the podcast container (which manages / coordinates the deliveries).
| # Only query for episodes that don't have a podcast container | ||
| # The container. Assume that if we have a container record, we don't need to poll. | ||
| eps_without_container = episodes.filter { |ep| ep.apple_persisted? && ep.missing_container? } | ||
|
|
There was a problem hiding this comment.
Trying to move special guards and state checks into more top level concerns (like PodcastContainer#delivery_settled?)
|
|
||
| # Get the latest state of the podcast containers | ||
| # which should include synced files | ||
| Apple::PodcastContainer.poll_podcast_container_state(api, eps) |
There was a problem hiding this comment.
Again, missing local state, this time in the files Apple attribute -- which gives a readout of the successfully processed/delivered files.
There was a problem hiding this comment.
I'm hitting this in prod (w/ test creds) just now. A podcast has episodes missing their container state, and upon retry I can't push that sync process forward. That should be fixed by this and other patches in this PR.
| @@ -327,14 +327,14 @@ def delivered? | |||
| def processed_errors? | |||
| return false unless asset_processing_state.present? | |||
|
|
|||
| processed_validation_failed? || processed_duplicate? | |||
There was a problem hiding this comment.
Uploading a duplicate file is not really an error.
app/models/apple/episode.rb
Outdated
| pdfs = feeder_episode.apple_podcast_delivery_files | ||
|
|
||
| pdfs.present? && pdfs.to_a.flatten.all?(&:apple_complete?) | ||
| feeder_episode.apple_podcast_container.skip_delivery? |
There was a problem hiding this comment.
Bit odd conceptually (the upload is complete when we're skipping the delivery?) Though I guess it's all the same - we skip the delivery when the upload is complete. Same check.
| @@ -327,14 +327,14 @@ def delivered? | |||
| def processed_errors? | |||
| return false unless asset_processing_state.present? | |||
|
|
|||
| processed_validation_failed? || processed_duplicate? | |||
| @@ -385,8 +385,8 @@ def drafting? | |||
| apple_json&.dig("attributes", "publishingState") == "DRAFTING" | |||
| end | |||
|
|
|||
| def apple_upload_complete? | |||
| feeder_episode.apple_podcast_container.skip_delivery? | |||
| def container_upload_complete? | |||
There was a problem hiding this comment.
@cavis I hope this clarifies. I renamed to emphasize the container upload semantics here. We need to deliver the audio file (Delivery, DeliveryFiles) and the container upload (PodcastContaner files attribute) will be complete (a file marked present).
The overall Apple::Episode#synced_with_apple? covers the rest. That method filters the episodes that go into the publishing routines in Apple::Publisher.
closes #685
This sets up a series of changes to help with upload retries:
filesattributes is a proxy to the validation and processing status on the Delivery/DeliveryFile models. It appears that Apple retains the overall container state and discards the delivery state, so likely building transitions in a state machine around the PodcastContainer will be better in the long run.duplicatestatus in the delivery was treated as an error and not properly covered by the success/error conditionalsskip_delivery?method and related helpers on the container to clarify retry logic.