Retry on error_apple non-terminal error #1148
Conversation
| @@ -19,7 +19,7 @@ class PublishingPipelineState < ApplicationRecord | |||
| scope :latest_failed_pipelines, -> { | |||
| # Grab the latest attempted Publishing Item AND the latest failed Pub Item. | |||
| # If that is a non-null intersection, then we have a current/latest+failed pipeline. | |||
| where(publishing_queue_item_id: PublishingQueueItem.latest_attempted.latest_failed.select(:id)) | |||
| where(publishing_queue_item_id: PublishingQueueItem.latest_attempted.latest_failed.order(id: :asc).select(:id)) | |||
There was a problem hiding this comment.
is that order(:id) appropriate to add to either the latest_attempted or latest_failed scopes?
Also, why :asc? That means the latest will be at the end? Wouldn't the most recently failed make sense as the first?
There was a problem hiding this comment.
Good point. The intent here was to order the output of the scope. But this attempt doesn't map cleanly between the two models (Queue and PublishingState). Removed!
Early on, I opted to avoid a base scope that defines ordering (IIRC my attempt caused some SQL slowness). Lately, I've been wishing that the output of these scopes follows a natural ordering (like :created, :rss, :completed) instead of a random ordering (as can happen with joins and aggregation).
In the console and in tests, its much easier to read the state transitions in the order they occurred.
Closes #1134
This includes the intermediate
error_applein the list of retryable error states. Prior to this, we had only considered terminal error states. With this PR, we will retry publishing pipelines having intermediateerror_applestates and terminalcomplete(success) states.