Render processing view for stalled uploads #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavis
requested changes
Oct 1, 2024
config/locales/en.yml
Outdated
| @@ -649,6 +649,7 @@ en: | |||
| title: MP3 Not Provided | |||
| processing: | |||
| hint: Processing | |||
| still_processing: Processing is taking longer than expected. Thank you for waiting. | |||
There was a problem hiding this comment.
Nice, I do like how this isn't highlighted in red now. Looks less angry:
I might prompt them that it's cool to click the retry button though... "Processing is taking longer than expected - you can continue waiting or retry"
There was a problem hiding this comment.
FWIW: I prefer the term "patience" over "waiting", ie: "thank you for your patience"... Throw in a llittle "Ope" and we might even get the user to chuckle in another wise frustrating moment.
I suggest:
"Ope, file processing is taking longer than expected - you can continue waiting or retry"
cavis
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1094
This PR solves a "hidden timeout" issue users were experiencing, by rendering a "still processing" message for "stalled" uploads. The solution i chose to solve for this was to opt for rendering the
_processingpartial instead of the_errorpartial for theupload_stalled?user conditional flow. I did this because i saw that the only difference betweenupload_processing?andupload_stalled?was theretryablecondition. Therefore, a "stalled" upload should still be processing. A side benefit to using the_processingpartial is that it continually polls the server, whereas the_errorpartial does not; if a "stalled" upload eventually completed, the_errorview wouldn't refresh on its own to a_completeview, whereas the_processingview does.Within the
_processingpartial, i added theretrybutton that is conditionally present in the_errorpartial, as well as a small (conditional) message underneath the field that notifies the user if the processing is taking longer than expected. This way, we keep the functionality for a user to choose to retry.@cavis for functional review
@brandonhundt for language review