Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide episode offset field from default feed view #1100

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

radical-ube
Copy link
Contributor

resolves #1096

This PR hides the Episode Offset field from the default feed view. This is because we don't want a user to have the option of setting an offset for the default feed. The ticket suggests possibly adding a validation, but one already exists and the testing for it seems logical and no additions seem to be needed.

Copy link
Member

@cavis cavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 didn't realize there was already a validation! But good to hide this anyways then.

@radical-ube radical-ube merged commit eb77112 into main Sep 26, 2024
3 checks passed
@radical-ube radical-ube deleted the feat/hide_episode_offset branch September 26, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No episode-offset-seconds on default feeds
2 participants