-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rails from 7.1.3.4 to 7.2.1 #1077
Conversation
Dependabot attempted to update this pull request, but because the branch |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
@dependabot recreate |
Looks like this PR is closed. If you re-open it I'll rebase it as long as no-one else has edited it (you can use |
@dependabot reopen |
@dependabot rebase |
1 similar comment
@dependabot rebase |
Bumps [rails](https://github.com/rails/rails) from 7.1.3.4 to 7.2.1. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v7.1.3.4...v7.2.1) --- updated-dependencies: - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
3ccb51d
to
be1cfc9
Compare
@@ -75,6 +75,7 @@ gem "excon" | |||
gem "faraday", "~> 0.17.4" | |||
gem "fiddle" | |||
gem "hyperresource" | |||
gem "mutex_m" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tangle of dependencies - but a nested dep of json-jwt
needs this, and will not be a default gem shortly. And I couldn't update to the latest json-jwt
because PrxAccess uses an older version of Faraday.
@@ -20,7 +20,7 @@ class PodcastDelivery < ApplicationRecord | |||
alias_method :container, :podcast_container | |||
alias_method :container=, :podcast_container= | |||
|
|||
enum status: { | |||
enum :status, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old enum foo: ["bar"]
syntax is deprecated.
@@ -8,6 +8,6 @@ | |||
StartPublishingPipelineJob.perform_now(create(:podcast)) | |||
end | |||
|
|||
mock.verify | |||
assert mock.verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rails now has a bunch of warnings if a test doesn't assert anything. So I added asserts to all these mock.verify
calls, and fixed a handful of other tests that weren't asserting.
Bumps rails from 7.1.3.4 to 7.2.1.
Release notes
Sourced from rails's releases.
... (truncated)
Commits
a11f0a6
Preparing for 7.2.1 release8b40780
Sync changelog2988deb
Update the description of when SQLite might make sense as the configured data...cd1b3db
Revert "Merge pull request #49769 from jonathanhefner/active_record-enum-non-...e314216
Merge pull request #52546 from Uaitt/config-assets-quiet-improvements33227d2
Merge pull request #52357 from Uaitt/clarify-upgrading-ruby-on-rails-guide2402fb4
Merge pull request #52637 from jlduran/cleanup-service-worker-white-space7600221
Fix linting issues in action_controller_overview.md90d9e12
Merge pull request #52138 from skipkayhil/hm-rack-input-is-optionalf42a784
Move the rewind code closer to the reason why we need to rewindDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)