Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggested chang to fix issue #20 (https://github.com/PRX/apn_on_rails/issues#issue/20) #25

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

suggested chang to fix issue #20 (https://github.com/PRX/apn_on_rails/issues#issue/20) #25

wants to merge 2 commits into from

Commits on Jan 27, 2011

  1. modified send_notifications_for_cert routine to decrease db load 

    Rather than making a query for each device, we can get all unsent
notifications for a given app with one SQL query.

The change also required a slight update of the app_spec.
    @andreasmueller
    andreasmueller committed Jan 27, 2011
    Configuration menu
    Copy the full SHA
    e6e9b8d View commit details
    Browse the repository at this point in the history

  2. specify :select in find to avoid :read_only 

    The APN::Notification.find call returned read-only ActiveRecords, which
can be prevented by specifying :select.

-> see http://stackoverflow.com/questions/639171/what-is-causing-this-activerecordreadonlyrecord-error
    @andreasmueller
    andreasmueller committed Jan 27, 2011
    Configuration menu
    Copy the full SHA
    9462d19 View commit details
    Browse the repository at this point in the history