Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicfeeds.net #704

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Publicfeeds.net #704

merged 3 commits into from
Sep 18, 2023

Conversation

cavis
Copy link
Member

@cavis cavis commented Sep 18, 2023

Adds the PUBLIC_FEEDS_URL_PREFIX env to the feeder stack.

@cavis cavis requested a review from farski September 18, 2023 20:36
@cavis cavis self-assigned this Sep 18, 2023
farski
farski approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@farski farski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you wanted to be even more bulletproof, you could do the interpolation in the template's constants, to reduce the chances of the value getting updated in some places but not others.

@cavis
Copy link
Member Author

cavis commented Sep 18, 2023

That /f path is such a Feeder-specific thing... I'm not sure why we'd use it elsewhere. But if we do... agreed with interpolating it in one place!

@cavis cavis merged commit b9a3d9b into main Sep 18, 2023
4 checks passed
@cavis cavis deleted the feat/publicfeedsdotnet branch September 18, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farski farski farski approved these changes

Assignees

@cavis cavis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cavis @farski