ADDED: a check for cmake version

[NehilDanis]

resolves the issue described in #201

[nachovizzo]

Hi @NehilDanis, thanks for putting an eye on this!

I was aware of the availability of SYSTEM since cmake 3.25, but I don't see how this made your build fail. If the flag is not available cmake should "ignore it". Or was it failing somehow?

[nachovizzo]

Hi @NehilDanis, thanks for putting an eye on this!

I was aware of the availability of SYSTEM since cmake 3.25, but I don't see how this made your build fail. If the flag is not available cmake should "ignore it". Or was it failing somehow?

[NehilDanis]

Hi @NehilDanis, thanks for putting an eye on this!

I was aware of the availability of SYSTEM since cmake 3.25, but I don't see how this made your build fail. If the flag is not available cmake should "ignore it". Or was it failing somehow?

It did not ignore it, that might have been the logical choice so that they would give backward compatibility. However, in my case it was failing. Below I attached the error I got. You can see that it is complaining about the incorrect number of arguments.

Ps. I didn't get the issue for Eigen, because I had it installed already, so it just didn't need to include the eigen.cmake

[nachovizzo]

@NehilDanis I reproduced the setup, and it was also failing. Thanks for fixing this.

I only changed a bit of the logic to avoid having to if in the code.

PS: If you have python available, you can now do pip install cmake and get the latest versions without hassle!!!