Avoid overflow errors with _get_radial_sum #980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_get_radial_sum
function currently overflows for large autocorrelation values. This can lead to negative values for the probability in thetwo_point_correlation
function.Problem
When using the two_point_correlation function with large autocorrelation values, I encountered overflow errors:
two_point_correlation
code), it causes an OverflowError with the message "Python int too large to convert to C long."Solution
To fix this issue, I: