hotfix import TerminationCondition for scipy v>=1.14 #2923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpc-dave
changed the title
hpc-dave
changed the title
|
The failed checks seem to be related to other numpy issues. I'll leave the fix for now as it is. |
|
Had to 'redo' this PR in #2931. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
With updating to scipy 1.14, import from
scipy.optimize.nonlinleads to an import errorTemporary Fix
Import from
scipy.optimize._nonlininsteadAdditional
The use of
TerminalConditionshould be reviewed. In my opinion, substituting the check done byTerminalConditionwould reduce the dependencies of the project and would not decrease readability.Related to #2922