Added more Scipy integrators to handle stiff problems #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2880 +/- ##
=====================================
Coverage 89.7% 89.7%
=====================================
Files 148 148
Lines 8662 8672 +10
=====================================
+ Hits 7774 7784 +10
Misses 888 888 |
ma-sadeghi
requested changes
Dec 24, 2023
Yea, I'll do that this week when I get back to work! |
|
I also have motivation to add more integrators to OpenPNM. I can help out with writing some of these unit tests. |
|
Hey @mkaguer, are we still interested in merging this PR? I have refreshed it by merge the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is only one scipy integrator classes that uses RK45. I created a general integrator class that uses RK45 by default called ScipyIntegrator, this is the parent class. Then, I created child classes that inherit from this class but pass different solvers. I added two more solvers currently not available, BDF and LSODA. These solvers work for stiff problems.