-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a patch release to fix matplotlib import error #2857
Conversation
Fixed dtype bug in isoutside function, and passing f to reflect basepoints #bug
# Fixed use of mpl's Substitution docstring helper to be version resistant #maint
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release #2857 +/- ##
=========================================
- Coverage 89.9% 89.8% -0.2%
=========================================
Files 148 148
Lines 8608 8624 +16
=========================================
+ Hits 7742 7747 +5
- Misses 866 877 +11 |
@jgostick Given that Matplotlib is going to remove this module altogether, can't we just host the code in our side? I think the license allows it. |
The windows builds are failing because the pypardiso team is having trouble with mkl again. They have a lot of recent activity and I'm sure they'll get this fixed soon. I am tempted to merge this now so we can get the pip release working with all version of mpl, which is more important than pardiso, I think? |
Maybe give them just a few more days? Either the issue is on pypardiso side, which I think will get fixed soon, or on Intel side, which probably won't get fixed soonish |
But technically pypardiso is not in our dependencies. This is only failing because we use it in some of our tests...but you're right, lets give it a few more days. |
Added try/except to getitem in Phase in case some settings are missing #bug
The deprecation of the
matplotlib.docstring
module tomatplotlib._docstring
was fixed in our previous patch, BUT it was not compatible with both new and old versions of matplotlib, so this patch uses a try/except to work with both versions.