Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ndarray dimension reduction in Transport.rate #2798

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

Arenhart
Copy link

@Arenhart Arenhart commented Aug 9, 2023

Fixes #2796

@ma-sadeghi
Copy link
Member

ma-sadeghi commented Aug 10, 2023

Looks good! I'll merge once the tests pass. Thank you @Arenhart once again!

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #2798 (8f56cb0) into dev (73bbc51) will not change coverage.
Report is 1 commits behind head on dev.
The diff coverage is 100.0%.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2798   +/-   ##
=====================================
  Coverage   90.2%   90.2%           
=====================================
  Files        146     146           
  Lines       8572    8572           
=====================================
  Hits        7740    7740           
  Misses       832     832           

@ma-sadeghi ma-sadeghi merged commit d933dc4 into PMEAL:dev Aug 10, 2023
12 checks passed
@ma-sadeghi ma-sadeghi changed the title fix ndarray dimension reduction Fix ndarray dimension reduction in Transport.rate Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traceback when getting flow rate of a network with a single throat
2 participants