Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert OR / HR fields with empty string to None #57

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nebfield
Copy link
Member

@nebfield nebfield commented Nov 1, 2024

One scoring file in the Catalog(PGSXX4900-ish) has the OR field set to an empty string, which currently raises a validation error

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (f570666) to head (7809c6c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files          54       54           
  Lines        3467     3467           
=======================================
  Hits         3107     3107           
  Misses        360      360           
Flag Coverage Δ
pgscatalog.core 92.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant