GS/HW: Backport some fixes from RT in RT PR #12185
Merged
+97
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_backportfixes
branch
2 times, most recently
from
bd904b1 to
28d2f39
Compare
JordanTheToaster
approved these changes
Jan 12, 2025
kamfretoz
approved these changes
Jan 12, 2025
refractionpcsx2
force-pushed
the
gs_backportfixes
branch
from
28d2f39 to
ff8c257
Compare
|
Fixed review items |
refractionpcsx2
force-pushed
the
gs_backportfixes
branch
from
ff8c257 to
4d57adb
Compare
lightningterror
approved these changes
Jan 12, 2025
|
Also improves Wild Arms 3 on DX: PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is some fixes I made in the RT in RT PR #11461 which I'm backporting to master as they should really be separate and they help outside of that, especially with a bug with a WWE game which was being investigated.
Fix misdetection of draw as clear, when it was a fog effect.
Fix preload target overlap behaviour and allow smaller widths which overlap.
Reduce target expansion when it doesn't need to due to subtractive blend on black (clamped).
Create a new target if a move is done with the same target, but the new position is outside of the target.
Fix AEM color requirement check for sources.
Debugging stuff changes:
Fix some of the HTML generation for the GS dump runner when frames are missing, this stopped the image comparer working.
Added the real BP for targets on to the name of render targets and depth targets (not really needed for the moment).
Added FOG parameters to vertex information text file.
Rationale behind Changes
These weren't really related but needed sorting in master for some problems.
Suggested Testing Steps
Test listed games and general game selections. Hopefully performance should be about the same/better.
Fixes:
Flower Sun and Rain:
Master:
PR:
Tales of Rebirth:
Master:
PR:
WWE SmackDown! Here Comes the Pain:
Master:
PR:
