Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings/Log: Print advanced settings warning on the log #12124

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

kamfretoz
Copy link
Contributor

Description of Changes

This PR adds a log entry that warns the user through the log if they have advanced options enabled.
Preview:
image

Rationale behind Changes

Helps with user support in the event a user has messed around with the advanced settings.

Suggested Testing Steps

See if the warning shows up correctly if the advanced settings are enabled. Also checks when its off too, or when the value is absent from the ini file.

Copy link
Contributor

@Mrlinkwii Mrlinkwii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
looks good to me

pcsx2/VMManager.cpp Outdated Show resolved Hide resolved
@kamfretoz
Copy link
Contributor Author

Also adjusted the log formatting a bit to be more consistent.

Before:
image

After:
image

pcsx2/R3000AInterpreter.cpp Outdated Show resolved Hide resolved
Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@F0bes F0bes merged commit 424951e into PCSX2:master Dec 28, 2024
11 checks passed
@kamfretoz kamfretoz deleted the Here-Be-Dragon branch December 28, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants