Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Update to Qt 6.8.0 on Windows and Linux #11854

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

JordanTheToaster
Copy link
Member

@JordanTheToaster JordanTheToaster commented Sep 27, 2024

Description of Changes

Qt 6.8 is now actually out so lets just roll with that. Mac is doing something weird that I am not qualified to figure out so I will leave that to someone else.

Fixes #11097

Rationale behind Changes

Fixes and security fixes are good.

Suggested Testing Steps

Make sure PCSX2 functions correctly and nothing got broken by the update such as menus themes checkboxes ect.

@PCSX2 PCSX2 deleted a comment from TABIROXX Sep 28, 2024
@TheLastRar
Copy link
Contributor

TheLastRar commented Sep 28, 2024

This Fixes #11097

However, I've notice that the game list gains a blue background every other entry on the Native Win11 theme
image
For reference, Qt 6.7.2 looks like this on Native Win11
image

Edit: The changes to the list view is related to fixing https://bugreports.qt.io/browse/QTBUG-124564
Regarding the row colour, I think that is tracked here https://bugreports.qt.io/browse/QTBUG-124563

@TheLastRar
Copy link
Contributor

TheLastRar commented Sep 28, 2024

Also, do we want to see if we can re add -DFEATURE_printsupport=OFF? (#11424)
I assume we had this prior to Qt 6.7.2 to speed up building Qt

@JordanTheToaster JordanTheToaster force-pushed the test branch 2 times, most recently from 3e27500 to f71d97e Compare September 28, 2024 14:27
@F0bes
Copy link
Member

F0bes commented Sep 29, 2024

Is this ready for review?

@JordanTheToaster JordanTheToaster marked this pull request as draft October 6, 2024 13:52
@JordanTheToaster JordanTheToaster changed the title Deps: Update to Qt 6.7.3 Deps: Update to Qt 6.8.0 Oct 8, 2024
@JordanTheToaster JordanTheToaster marked this pull request as ready for review October 8, 2024 08:58
@JordanTheToaster JordanTheToaster force-pushed the test branch 3 times, most recently from 32af814 to 619a3f6 Compare October 8, 2024 09:09
@JordanTheToaster JordanTheToaster marked this pull request as draft October 8, 2024 09:11
@JordanTheToaster JordanTheToaster force-pushed the test branch 2 times, most recently from 794071e to 0fa4396 Compare October 8, 2024 11:21
@JordanTheToaster JordanTheToaster changed the title Deps: Update to Qt 6.8.0 Deps: Update to Qt 6.8.0 on Windows and Linux Oct 8, 2024
@JordanTheToaster JordanTheToaster marked this pull request as ready for review October 8, 2024 11:39
Copy link
Contributor

@kamfretoz kamfretoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux Appimage and flatpak work fine.

@F0bes F0bes merged commit 1e9a248 into PCSX2:master Oct 8, 2024
12 checks passed
@JordanTheToaster JordanTheToaster deleted the test branch October 10, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Sizing of QT spinboxes is too small on native Win11 theme
6 participants