Qt: Clean and remove empty game settings #11190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Dependencies
Mrlinkwii
approved these changes
May 4, 2024
JordanTheToaster
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When modifying game settings, it's pretty easy to end up with a file full of empty sections. That's a bit messy.
This PR makes the interface clean out empty sections, as well as removing empty gamesettings files completely if no settings are changed.
And a couple of other random tidy-ups.
Rationale behind Changes
Less mess in
gamesettingsdirectory.Suggested Testing Steps
Test game settings. Make sure files are created, and get removed when the last changed setting is reset.
Make sure input profiles are still creatable and editable.
Make sure speed limiter and fast forward boot still works as expected.