Timers: Fix up some timer behaviour #11173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
counter_bugfix
branch
from
b71cbdd to
0df43cc
Compare
JordanTheToaster
approved these changes
May 1, 2024
Mrlinkwii
approved these changes
May 1, 2024
kamfretoz
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fix up some timer behaviour on EE and IOP
Rationale behind Changes
Introduced a bug in the previous PR by accident, realised that if the game didn't update gated counters before hsync/vsync and the counter got reset, it would retain the old value.
Also tested HSync timing on the PS2, and corrected it in PCSX2.
Suggested Testing Steps
test hsync timing sensitive games, i guess. No known fixes.