GS/Vulkan: Drop feedback loop extension #11124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently this causes GPU crashes on RDNA3, and didn't provide any tangible benefit for NVIDIA. I'll replace this at some point with dynamic rendering local reads, either before or after the GPUDevice transition.
|
@stenzek
GS Dump: Tested on Windows 10 19044 with AMD Radeon Graphics Drivers 24.6.1 WHQL I know y'all don't accept issues related to upscaling but I still wanted to inform you about this regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Apparently this causes GPU crashes on RDNA3, and didn't provide any tangible benefit for NVIDIA.
I'll replace this at some point with dynamic rendering local reads, either before or after the GPUDevice transition.
Rationale behind Changes
Might fix the crashes on RDNA3.
Suggested Testing Steps
Compare performance in barrier-heavy games on NVIDIA, make sure it is unaffected.
See if it fixes the GPU crashes on RDNA3.