-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qt/PAD: Enable/Disable Player LED for DualSense Controllers in Enhanced mode #10864
Conversation
This sounds like a bad idea, since we use the player ID for allocating the identifier in |
33f9030
to
10ec2db
Compare
Good call out. I've completely changed this PR to achieve this with the SDL Hint instead now. Ready for review. |
Player LED on and off on my DualSense work fine. Though for expansion have you thought of adding specific things that DS4Windows add like where the player LED is you can show battery percentage or enable the mute button (orange light) which actually reduces battery usage (controller constantly sends audio even when it's not needed). Maybe this might be asking out of scope. |
yeah this thang works has my seal of approval 10/10 |
Thanks for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on arch linux with the appimage!
Didn't test the flatpak
10ec2db
to
26e02c0
Compare
Description of Changes
This change adds a toggle to enable/disable the Player LED on DualSense controllers.
Not to be confused with the primary LED. The Player LED is a non-customizable bright white array of white LEDs that indicate the player number. Image of before and after.
The UI change is added to the LEDSettingsDialog
Rationale behind Changes
Suggested Testing Steps
-- if on master --
-- if on this branch --