Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Add automatic refreshing on 1 second interval #10860

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Daniel-McCarthy
Copy link
Contributor

Implements #10840

Description of Changes

The debugger now refreshes/updates it's widgets once a second so that the user does not need to interact with the debugger to know when data/state changes.

PCSX2 - Auto-Refresh

Note: I am also considering eventually allowing the user to configure this interval, however have not implemented it here. It is fixed to a one second interval agreed upon in #10840.

Rationale behind Changes

Allows the user to watch data/state changes without intervention/interaction.

Suggested Testing Steps

Validating everything that should be updating gets updated while the cpu is alive.

@stenzek
Copy link
Contributor

stenzek commented Feb 26, 2024

Keep in mind the values you see here likely won't be correct, since it's a race condition to be reading this state while the VM isn't paused.

Copy link
Member

@F0bes F0bes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that extra line it looks good to me.

pcsx2-qt/Debugger/CpuWidget.h Outdated Show resolved Hide resolved
The debugger now refreshes/updates it's widgets once a second so that the user does not need to interact with the debugger to know when data/state changes.
@refractionpcsx2 refractionpcsx2 merged commit a903387 into PCSX2:master Feb 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants