Debugger: Memory search increased/decreased/changed + results count #10837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Increased, Increased By, Decreased, Decreased By, Changed, Changed By, Not Changed
.Not Equals, Changed, Not Changed
Searching...
when a memory search is in progress, and<number> results found
on search completion.Refactors how search results are stored so that we can identify the prior value of a search result to compare against when filtering (as is required for all of the new search comparisons).
Adds a 2 way lookup table so that we can manage which comparison types are in the
QComboBox
since we can no longer convert the selection index directly to an enum since the options change depending on the selected search type and if there are existing results that match the current search type.Rationale behind Changes
Suggested Testing Steps
This impacts all search types/comparisons. Thorough testing/sanity checking of search results would be excellent.
I highly recommend testing with at least one integer type (e.g. 16 bit), at least one decimal type (decimal or float), and at least one array style type (string or array) as these are each handled different from each other in some ways.
Note:
Some minor cleanup of comments, and renaming of some
.ui
components that had generic names.Quick Demonstrations
Increased/Decreased/Changed (and results count)
Array/String comparison options when filtering
Showing comparisons that are for filtering only *only after* initial search