GS/HW: Preload whole target on match #10835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refractionpcsx2
force-pushed
the
gs_preloadwhole
branch
from
a809033 to
66dbb11
Compare
JordanTheToaster
approved these changes
Feb 21, 2024
kamfretoz
approved these changes
Feb 21, 2024
Mrlinkwii
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Preload whole target when upload matches, instead of just recent dirty area.
Rationale behind Changes
This was a fix for Medal of Honor European Assault which basically creates a new target at 0x3100 at 64x64, but it was getting confused with an existing target, so after the changes of 1.7.5328, the target was getting killed, and it was preloading from memory (as it should) but only half of it, instead of the whole thing from the mem clear, because we don't add a transfer when it attempts to continue with the clear.
Suggested Testing Steps
Test Medal of Honor European Assault (Though this will be nullified by master anyway) to check for black spots. Also check MLB 09 - The Show and Sven-Goran Erikssons World Manager 2002. Maybe smoke test some other games.
Medal of Honor European Assault (nullified by another solution on master):
Master:
PR:
MLB 09 - The Show:
Master:
PR:
Sven-Goran Erikssons World Manager 2002:
Master:
PR: