Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameDB: NTSC-J Overhaul #10766

Merged
merged 1 commit into from
Feb 13, 2024
Merged

GameDB: NTSC-J Overhaul #10766

merged 1 commit into from
Feb 13, 2024

Conversation

maekawa-mugi
Copy link
Contributor

@maekawa-mugi maekawa-mugi commented Feb 3, 2024

Description of Changes

  • Fixed typo/wrong name/name-sort/name-en.
  • Replaced full-width tilde (U+FF5E) with wave dash (U+301C).
  • Removed VW067-J1 since it is a mere number for catalog purpose but not game ID.
  • According to SCE's internal title database (mentioned in PS3 compatibility list):
    • Preffixed some suffixed "low-cost edition" suffix.
    • Replaced "PS2 the Best" with "PlayStation 2 the Best".

Rationale behind Changes

More accurate name/name-sort/name-en.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a contribution to PCSX2

As this is your first pull request, please be aware of the contributing guidelines.

Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.

Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!

@RedDevilus
Copy link
Contributor

Please don't remove any Romaji, they should be put in a seperate line as name-en:

PAPX-90236:
  name: "Minna Daisuki Katamari Damacy"
  name: みんな大好き塊魂 体験版
  name-sort: みんなだいすきかたまりだましい たいけんばん

Into

PAPX-90236:
  name: みんな大好き塊魂 体験版
  name-sort: みんなだいすきかたまりだましい たいけんばん
  name-en: "Minna Daisuki Katamari Damacy"

And dozens of others like fantavision, DVD Player, Saru Get You, ...

Also

  name: "dot hack - Quarantine Part 4"
  name: ".hack Quarantine Part 4"

Maybe better fitted to change the name sort instead.

So that's it improves the GameDB for all players and not just Japanese-only readers. Still good job, GameDB can be a pain in the arse.

@maekawa-mugi
Copy link
Contributor Author

What do you mean of "Please don't remove any Romaji"?
I thought that the correct title was not entered, but the incorrect English title was entered.

@RedDevilus
Copy link
Contributor

RedDevilus commented Feb 3, 2024

SLPM-74003:
  name: クラッシュ・バンディクー4 さくれつ!魔神パワー PS2 the Best
  name-sort: くらっしゅ・ばんでぃくー4 さくれつ!まじんぱわー PS2 the Best
  name-en: "Crash Bandicoot 4 - Sakuretsu! Majin Power! [PS2 The Best]"
  region: "NTSC-J"

The above is already inside GameDB and how it should be formatted.

vs some of your changes:

  PAPX-90236:
  name: みんな大好き塊魂 体験版
  name-sort: みんなだいすきかたまりだましい たいけんばん
  region: "NTSC-J"
  PAPX-90330:
  name: "サルゲッチュ2 ウッキーウッキーディスク"
  name-sort: さるげっちゅ2 うっきーうっきーでぃすく
  region: "NTSC-J"

So if people pick the option prefer English Titles, they can see everything in the Roman Alphabet and also not overlook missing gamefixes now or future changes to same titles in future.

@maekawa-mugi maekawa-mugi marked this pull request as draft February 3, 2024 11:48
@maekawa-mugi
Copy link
Contributor Author

I was accidentally overwritten name-en during editing. Correcting...

@refractionpcsx2
Copy link
Member

I only had a cursory look, since I don't speak japanese, but two things I noticed.

  1. regarding the .hack games, we named them as such to remove reserved characters from the names, because the names in there also serve as filenames for covers. See here GameDB: Use proper names for .hack// titles #10475
  2. Why did you remove the "Simple 2000 series" parts from those titles? they are still part of those titles, as they are part of that series.
    As for the Japanese modifications I can't comment. maybe @TellowKrinkle and @knight-ryu12 could give it a look.

@TellowKrinkle
Copy link
Member

BTW you can update a PR by force-pushing to the branch it's based on (git push --force if you use git command line) instead of closing the PR and opening a new one @maekawa-mugi

@TellowKrinkle
Copy link
Member

Or if you can't do that in your git client, add the necessary commits on top and ask one of us to do the force push before merging

@TellowKrinkle
Copy link
Member

@maekawa-mugi .hack should be fine, you can fix them all: #10780 (comment)

@maekawa-mugi
Copy link
Contributor Author

maekawa-mugi commented Feb 5, 2024

Stopped due to computer and health failure

@TellowKrinkle
Copy link
Member

Is it okay with you if I continue these changes on my own PR?

@maekawa-mugi maekawa-mugi reopened this Feb 11, 2024
@maekawa-mugi maekawa-mugi changed the title GameDB: NTSC-J Fixes GameDB: NTSC-J Overhaul Feb 11, 2024
@maekawa-mugi maekawa-mugi marked this pull request as ready for review February 12, 2024 16:19
@maekawa-mugi
Copy link
Contributor Author

Simple prefix deletion was reverted.

@maekawa-mugi
Copy link
Contributor Author

trailing space removed

Copy link
Member

@TellowKrinkle TellowKrinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all this

@TellowKrinkle TellowKrinkle merged commit e1fc414 into PCSX2:master Feb 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants