-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GameDB: NTSC-J Overhaul #10766
GameDB: NTSC-J Overhaul #10766
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting a contribution to PCSX2
As this is your first pull request, please be aware of the contributing guidelines.
Additionally, as per recent changes in GitHub Actions, your pull request will need to be approved by a maintainer before GitHub Actions can run against it. You can find more information about this change here.
Please be patient until this happens. In the meantime if you'd like to confirm the builds are passing, you have the option of opening a PR on your own fork, just make sure your fork's master branch is up to date!
Please don't remove any Romaji, they should be put in a seperate line as name-en:
Into
And dozens of others like fantavision, DVD Player, Saru Get You, ... Also
Maybe better fitted to change the name sort instead. So that's it improves the GameDB for all players and not just Japanese-only readers. Still good job, GameDB can be a pain in the arse. |
What do you mean of "Please don't remove any Romaji"? |
The above is already inside GameDB and how it should be formatted. vs some of your changes:
So if people pick the option prefer English Titles, they can see everything in the Roman Alphabet and also not overlook missing gamefixes now or future changes to same titles in future. |
I was accidentally overwritten name-en during editing. Correcting... |
I only had a cursory look, since I don't speak japanese, but two things I noticed.
|
BTW you can update a PR by force-pushing to the branch it's based on ( |
Or if you can't do that in your git client, add the necessary commits on top and ask one of us to do the force push before merging |
@maekawa-mugi |
Stopped due to computer and health failure |
Is it okay with you if I continue these changes on my own PR? |
Simple prefix deletion was reverted. |
trailing space removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing all this
Description of Changes
Rationale behind Changes
More accurate name/name-sort/name-en.