Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
spu2-x: Remove unused DirectSound 5.1 module
It was copied over from SPU2ghz but never actually used.
- Loading branch information
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you can't make it work? :P
I think there were some requests for 5.1 in the forum. Although only a couple of games support it IIRC.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed.
I think this was left unused because in the end giga never managed to get AC3 and DTS decoding to work (poor guy, all that work alone).
But technically a perfect emulator should. And those are 6 channels.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Portaudio and xaudio2 modules seem to have 5.1? Or at least it looks like they do.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ehrm.. @gigaherz help plz?
Perhaps this directsound was just something "postponed" back when the original project started, while portaudio and xaudio2 modules were just added regardless of anything?
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to be able to say exactly what this was for and such, but I have no memories related to this. XD
What I do remember, is that SPU2-X has (or used to have) options for using basic surround expansion (just extending the front speakers into the back), and the experimental Pro-Logic II dematrixer. However, I don't recall ever using them outside of XAudio2 and PortAudio.
Chances are we dropped the DSound module simply because XAudio2 served the same purpose (DSound on XP, WASAPI on Vista+), and there was no need to maintain two modules.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait.. Did we drop directsound? I had miss this part.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Though since we don't support XP anymore it might be a good idea.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant Dsound 5.1, not the whole dsound
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, ok.
Anyway, call me stale, but directsound still has its points, for as much as prolly nobody here care for access to audio buffers for remixing.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure DSound still has its uses, but for most practical purposes, XAudio2 works just the same, except with a nicer API. And for lower-level audio streaming, there's WASAPI, which is just better than raw KS (kernel streaming -- a painful headache to get working).
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I mean, I'm sure that for 99% of uses Xaudio2 is still better.
Still, as for XP drop, as long as it doesn't create any particular burden, I see no reason for ditching it.
Did you mean low latency? Because for that, technically, ASIO (included in portaudio) is even neater.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant low-level. For low-latency there is ASIO, yes, but only a tiny % of the sound cards have asio drivers, so it may as well not be there.
To clarify: there's things like ASIO4ALL, but they just wrap the KS/WASAPI interface, so it's not any lower latency than using WASAPI exclusive mode.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dafuq, why did github decide to complete the "yes" as an username? I did not do that.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so fast :D
And, regardless, like above: as long as it doesn't tamper with the remainder stuff, I don't see why screwing even those few users for no gain.
Nope?
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More than just a couple. There are dozens. It's something PCSX2 should definitely support. Most people probably think it does because of the audio expansion mode.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another call to at least add Dolby/DTS to TODO list, never forgetti.
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone manages to decode the SPDIF bitstream into hearable audio, I'll donate them a beer or two ;P
eddabf9There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#432