Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare legacy support for voice actions #972

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Fakorede
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of changes

It enables support for voice actions on some infotainment systems which require this intent-filter

Fixes the following issues

Any additional information

APK testing

not required

Due Diligence

Copy link
Owner

@OxygenCobalt OxygenCobalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Is this a simple "flag" that systems check for before forwarding media intents to AuxioService, or is it an actual activity launch scenario that needs to be handled? If latter, you probably need to take a look at the intent handling flow (MainActivity -> DeferredPlayback -> ExoPlaybackStateHolder) and modify that to handle the new intent class @Fakorede

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants