raidboss: Fix issues with asura timeline syncs #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
raidboss
JLGarber
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Blergh, I think I need to change my editor font. I'm fairly sure no other 8 <--> B confusion has made its way in, but once is enough. Always copy-paste stuff, I suppose.
Not sure why I left all the preview syncs in when I wrote this. The changes you made are sensible.
|
Any thoughts on the display issue with |
|
I think your proposed change should cover it. Maaaaybe shorten it to something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had this pop up in duty roulette and noticed some issues.
Typo in Iconography ability IDs, and syncs on lines less than 3 seconds apart without a shortened sync window.
There's another issue where the timeline doesn't have the actual text for the
Iconographylines, I think due to the text being too long and being a single word?Maybe this needs a different
replaceTextentry such as the following?