Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use gridmap code #238

Merged
merged 2 commits into from
Aug 7, 2024
Merged

use gridmap code #238

merged 2 commits into from
Aug 7, 2024

Conversation

juliettelavoie
Copy link
Contributor

@juliettelavoie juliettelavoie commented Aug 7, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Use the same code for creating the colormap in scattermap as in gridmap

Does this PR introduce a breaking change?

Other information:

sarahclaude
sarahclaude approved these changes Aug 7, 2024
View reviewed changes
Copy link
Collaborator

@sarahclaude sarahclaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Juliette!

@juliettelavoie juliettelavoie merged commit 40dda3f into main Aug 7, 2024
12 checks passed
@juliettelavoie juliettelavoie deleted the fix-scatter branch August 7, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahclaude sarahclaude sarahclaude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with scatter map
2 participants
@juliettelavoie @sarahclaude