Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/improve some templates #38

Merged
merged 18 commits into from
May 13, 2024
Merged

Enh/improve some templates #38

merged 18 commits into from
May 13, 2024

Conversation

bzah
Copy link

@bzah bzah commented May 2, 2024 •
edited
Loading

Closes #37

This PR upstream the comments made for xncml in xarray-contrib/xncml#76

TODO

  • Make sure a generated project works as expected.

Abel Aoun added 2 commits May 2, 2024 17:37
enh: Update some template from xncml feedback
42ebdab
enh: Update CONTRIBUTING.rst
eb54552 
Apply same reccomendations as in the templates for
the cookicutter root CONTRIBUTING.rst.
@bzah bzah marked this pull request as draft May 2, 2024 15:43
@bzah bzah marked this pull request as ready for review May 3, 2024 11:23
Abel Aoun and others added 3 commits May 3, 2024 13:43
fix: remove creation of date in CHANGES.rst
de77700 
Only bump2version allow this  syntaxt to add a date when bumping.
We use bumpmyversion here.
@Zeitsperre
optional default value
146f513
@Zeitsperre
add prompts
b7ebd24
Zeitsperre
Zeitsperre requested changes May 6, 2024
View reviewed changes
Copy link

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions, but it would be good to make sure that the existing projects that use development/release versioning aren't negatively impacted.

{{cookiecutter.project_slug}}/pyproject.toml Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/pyproject.toml Outdated Show resolved Hide resolved
CONTRIBUTING.rst Show resolved Hide resolved
@bzah bzah mentioned this pull request May 8, 2024
Merged
@Zeitsperre Zeitsperre mentioned this pull request May 13, 2024
Closed
Zeitsperre
Zeitsperre approved these changes May 13, 2024
View reviewed changes
Copy link

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're just about done. Excited to see the changes in action!

CONTRIBUTING.rst Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/CHANGES.rst Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/docs/releasing.rst Outdated Show resolved Hide resolved
@bzah bzah merged commit 33f63b3 into main May 13, 2024
6 checks passed
@bzah bzah deleted the enh/improve_some_templates branch May 13, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestions of improvements
2 participants
@bzah @Zeitsperre