Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.rst suggestions #28

Merged
merged 6 commits into from
Nov 29, 2023
Merged

CONTRIBUTING.rst suggestions #28

merged 6 commits into from
Nov 29, 2023

Conversation

Zeitsperre
Copy link

@Zeitsperre Zeitsperre commented Nov 29, 2023 •
edited
Loading

Fixes #27

What's changed?

  • Mention is made to conda-libmamba-solver or mamba for handling dependency solving issues.
  • The contributing documentation is clearer on a few procedures
  • The default setting of bump-my-version is not to tag on bump. This means that when we create new releases, we need to manually tag that release on the main branch. The bump-version.yml will still create development version tags.

@Zeitsperre Zeitsperre added the documentation Improvements or additions to documentation label Nov 29, 2023
@Zeitsperre Zeitsperre self-assigned this Nov 29, 2023
RondeauG
RondeauG approved these changes Nov 29, 2023
View reviewed changes
Copy link

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

{{cookiecutter.project_slug}}/CONTRIBUTING.rst Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/CONTRIBUTING.rst Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/CONTRIBUTING.rst Outdated Show resolved Hide resolved
{{cookiecutter.project_slug}}/CONTRIBUTING.rst Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit 844fb96 into main Nov 29, 2023
6 checks passed
@Zeitsperre Zeitsperre deleted the contributing-fixes branch November 29, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible improvements to CONTRIBUTING and installation
2 participants
@Zeitsperre @RondeauG