Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/article #95

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Fix/article #95

merged 2 commits into from
Aug 15, 2024

Conversation

david-parkk
Copy link
Member

✏️ 작업 개요

⛳ 작업 분류

  • update 버그 해결
  • save 버그 해결
  • 테스트 코드 작성

🔨 작업 상세 내용

  1. 불필요한 쿼리 수를 최대한 줄였습니다.

💡 생각해볼 문제

  • 메뉴 및 메뉴판 API #41 에 관련된 내용인데 delete하고 update하는 로직에 em.flush를 꼭 해야하는 이유가 납득이 되지 않았는데 동일한 문제점을 겪었습니다.
  • flush 문제는 아니고, 양방향 연관관계를 온전하게 끊어 줘야 entitymanger 입장에서 삭제된 엔티티로 인지하네요
  • 이외에도 예상하지 못한 문제(cascade를 설정하지 않았음에도 내부 엔티티가 저장되는 문제)가 있었는데 JPA 어렵네요 😢

@david-parkk david-parkk added the 🐛 버그 Something isn't working label Aug 15, 2024
Copy link

Test Results

14 tests   14 ✅  1s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 541755d.

@david-parkk david-parkk merged commit 4798f4e into main Aug 15, 2024
3 checks passed
@david-parkk
Copy link
Member Author

/아워메뉴 배포

@david-parkk
Copy link
Member Author

🌎 배포하였습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 버그 Something isn't working 📡 자동 배포
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants