Skip to content

Commit

Permalink
Merge pull request #252 from OuhscBbmc/dev
Browse files Browse the repository at this point in the history
submit to CRAN
  • Loading branch information
wibeasley authored Sep 21, 2019
2 parents e641641 + b671698 commit 285fe7e
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 22 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ utility/
^.*\.o$
^_pkgdown\.yml$
^docs$
^CRAN-RELEASE$
2 changes: 2 additions & 0 deletions CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This package was submitted to CRAN on 2019-09-21.
Once it is accepted, delete this file and tag the release (commit 6d76e90b4c).
13 changes: 2 additions & 11 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Description: Encapsulates functions to streamline calls from R to the REDCap
University. The Application Programming Interface (API) offers an avenue
to access and modify data programmatically, improving the capacity for
literate and reproducible programming.
Version: 0.9.10.9003
Date: 2019-08-14
Version: 0.10.1
Date: 2019-09-20
Authors@R: c(person("Will", "Beasley", role = c("aut", "cre"), email =
"[email protected]", comment = c(ORCID = "0000-0002-5613-5006")),
person("David", "Bard", role = "ctb"),
Expand All @@ -19,15 +19,6 @@ Authors@R: c(person("Will", "Beasley", role = c("aut", "cre"), email =
role = "ctb"), person("Hao", "Zhu",
role = "ctb",
comment = c(ORCID = '0000-0002-3386-6076')))
Author: Will Beasley [aut, cre],
David Bard [ctb],
Thomas Wilson [ctb],
John J Aponte [ctb],
Rollie Parrish [ctb],
Benjamin Nutter [ctb],
Andrew Peters [ctb],
Hao Zhu [ctb]
Maintainer: Will Beasley <[email protected]>
URL: https://github.com/OuhscBbmc/REDCapR, http://ouhsc.edu/bbmc/,
http://project-redcap.org
BugReports: https://github.com/OuhscBbmc/REDCapR/issues
Expand Down
19 changes: 9 additions & 10 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Description
-----------------------------------------------
This submission addresses breaking tests related to changing packages underneath (mostly the curl package I think; described in #154). Kurt had requested that I update the CRAN version a few weeks ago. I made the changes and was waiting until [dplyr 0.6.0](https://blog.rstudio.org/2017/04/13/dplyr-0-6-0-coming-soon/) was released on CRAN, since dplyr is used in several important places. But the release date appears to have been pushed back, and the RTools checks are working with the dev version anyway.
This submission includes new features and also addresses some (soon-to-be) breaking changes in the libraries underneath.

Thank you for taking the time to review my submission, and please tell me if there's something else I should do for CRAN. -Will Beasley

Expand All @@ -10,22 +10,21 @@ Test environments

The win-builder and a local machine have used the CRAN version of dplyr. The others have used the current GitHub master version of dplyr.

* Local Ubuntu, R 3.4.0 patched
* Local Win8, R 3.4.0 patched
* Local Win8, R 3.4.0 devel
* [win-builder](https://win-builder.r-project.org/3wAMI67afYVu/) (version="R-devel")
* [Travis CI](https://travis-ci.org/OuhscBbmc/REDCapR), Ubuntu 12.04 LTS
* Local Ubuntu, R 3.6.1 patched
* Local Win8, R 3.6.1 patched
* [r-hub](https://builder.r-hub.io/status/REDCapR_0.10.1.tar.gz-b2178285b2ac4196bce254c553eaab50)
* Ubuntu Linux 16.04 LTS, R-release, GCC
* Fedora Linux, R-devel, clang, gfortran
* [win-builder](https://win-builder.r-project.org/3wAMI67afYVu/), development version.
* [Travis CI](https://travis-ci.org/OuhscBbmc/REDCapR), Ubuntu 14.04 LTS
* [AppVeyor](https://ci.appveyor.com/project/wibeasley/REDCapR), Windows Server 2012


R CMD check results
-----------------------------------------------

* No ERRORs or WARNINGs on any builds.

* No NOTEs on win-builder.

* No other unexplainable NOTEs on the other builds.
* There is one NOTE related to the url `https://bbmc.ouhsc.edu/redcap/api/`. This url is the root of the API, and not intended to be navigated to by humans.


Downstream dependencies
Expand Down
2 changes: 1 addition & 1 deletion utility/refresh.R
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ test_results_not_checked <- testthat::test_dir("./tests/manual/")
# devtools::check(force_suggests = FALSE)
devtools::check(cran=T)
# devtools::check_rhub(email="[email protected]")
# devtools::build_win(version="R-devel") #CRAN submission policies encourage the development version
# devtools::check_win_devel() # CRAN submission policies encourage the development version
# devtools::revdep_check(pkg="REDCapR", recursive=TRUE)
# devtools::release(check=FALSE) #Careful, the last question ultimately uploads it to CRAN, where you can't delete/reverse your decision.

0 comments on commit 285fe7e

Please sign in to comment.