Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes "Long strings of text break profile width" #44

Closed
wants to merge 6 commits into from
Closed

Fixes "Long strings of text break profile width" #44

wants to merge 6 commits into from

Conversation

FujiwaraSatomi
Copy link
Contributor

@FujiwaraSatomi FujiwaraSatomi commented Nov 29, 2022 •
edited
Loading

fixes #43
I edited the css of general (global), which may have interfered with other pages.

Best code for testing styles:

<style>
.osekai__2col_col1, .osekai__2col_col2 {
    flex: 1;
    max-width: 100%;
    min-width: 0;
}

.profiles__cover-back-info_text {
    max-width: 100%;
}

.profiles__cover-back-info_text p:not(#arrival__date):not(#hardware) {
    text-overflow: ellipsis;
    white-space: nowrap;
    overflow-x: hidden;
}

.comments__comment-top-text {
    word-break: break-word;
}
</style>

@FujiwaraSatomi
Copy link
Contributor Author

FujiwaraSatomi commented Nov 29, 2022 •
edited
Loading

image
image

@minusQuantumNeko minusQuantumNeko removed the request for review from EXtremeExploit November 29, 2022 08:13
@minusQuantumNeko minusQuantumNeko added Profiles Related to Profiles App Code For Issues or Pull Requests related to code Design For Issues or Pull Requests related to design labels Nov 29, 2022
@Tanza3D
Copy link
Member

Tanza3D commented Nov 29, 2022

hm, it works, but i feel there must be a better way to go about it. i'll look into it and if i can't find anything i'll merge

@Tanza3D
Copy link
Member

Tanza3D commented Nov 29, 2022

@yuzupon1133 applying this code removes the need for the extremely specific max-width requirements, please replace with it. the text modification with ellipsis is good

.osekai__2col_col1, .osekai__2col_col2 {
  flex: 1;
  max-width: 100%;
  min-width: 0;
}

(you will need to edit global/css/main.css)

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 29, 2022
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 29, 2022
osekai-team pushed a commit that referenced this pull request Sep 26, 2024
@Tanza3D
Merge pull request #44 from EXtremeExploit/medals-search-tags
7b2d956 
medals: Make searching tag based
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tanza3D Tanza3D Awaiting requested review from Tanza3D

Assignees
No one assigned
Labels
Code For Issues or Pull Requests related to code Design For Issues or Pull Requests related to design Profiles Related to Profiles App size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profiles Long strings of text break profile width
3 participants
@FujiwaraSatomi @Tanza3D @minusQuantumNeko