Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic deploy 005 - Delegate OS yield from the SwapX SWPx/OS pool to SwapX Treasury #2372

Merged
merged 7 commits into from
Jan 30, 2025

Conversation

naddison36
Copy link
Collaborator

@naddison36 naddison36 commented Jan 29, 2025

Changes

Governance

Schedule batch

{
  "version": "1.0",
  "chainId": "146",
  "createdAt": 1738143058,
  "meta": {
    "name": "Transaction Batch",
    "description": "",
    "txBuilderVersion": "1.16.1",
    "createdFromSafeAddress": "0xbe2AB3d3d8F6a32b96414ebbd865dBD276d3d899",
    "createdFromOwnerAddress": ""
  },
  "transactions": [
    {
      "to": "0x31a91336414d3B955E494E7d485a6B06b55FC8fB",
      "value": "0",
      "data": null,
      "contractMethod": {
        "inputs": [
          {
            "type": "address[]",
            "name": "targets"
          },
          {
            "type": "uint256[]",
            "name": "values"
          },
          {
            "type": "bytes[]",
            "name": "payloads"
          },
          {
            "type": "bytes32",
            "name": "predecessor"
          },
          {
            "type": "bytes32",
            "name": "salt"
          },
          {
            "type": "uint256",
            "name": "delay"
          }
        ],
        "name": "scheduleBatch",
        "payable": false
      },
      "contractInputsValues": {
        "targets": "[\"0xb1e25689D55734FD3ffFc939c4C3Eb52DFf8A794\"]",
        "values": "[\"0\"]",
        "payloads": "[\"0x9d01fc720000000000000000000000009cb484fad38d953bc79e2a39bbc93655256f0b16000000000000000000000000896c3f0b63a8dae60afce7bca73356a9b611f3c8\"]",
        "predecessor": "0x0000000000000000000000000000000000000000000000000000000000000000",
        "salt": "0x4dc1f751f0d410a7004e7b3b3e3f15481532b5f73d7c694cdfcf3351eec42c27",
        "delay": "86400"
      }
    }
  ]
}

Execute batch

{
  "version": "1.0",
  "chainId": "146",
  "createdAt": 1738143058,
  "meta": {
    "name": "Transaction Batch",
    "description": "",
    "txBuilderVersion": "1.16.1",
    "createdFromSafeAddress": "0xbe2AB3d3d8F6a32b96414ebbd865dBD276d3d899",
    "createdFromOwnerAddress": ""
  },
  "transactions": [
    {
      "to": "0x31a91336414d3B955E494E7d485a6B06b55FC8fB",
      "value": "0",
      "data": null,
      "contractMethod": {
        "inputs": [
          {
            "type": "address[]",
            "name": "targets"
          },
          {
            "type": "uint256[]",
            "name": "values"
          },
          {
            "type": "bytes[]",
            "name": "payloads"
          },
          {
            "type": "bytes32",
            "name": "predecessor"
          },
          {
            "type": "bytes32",
            "name": "salt"
          }
        ],
        "name": "executeBatch",
        "payable": true
      },
      "contractInputsValues": {
        "targets": "[\"0xb1e25689D55734FD3ffFc939c4C3Eb52DFf8A794\"]",
        "values": "[\"0\"]",
        "payloads": "[\"0x9d01fc720000000000000000000000009cb484fad38d953bc79e2a39bbc93655256f0b16000000000000000000000000896c3f0b63a8dae60afce7bca73356a9b611f3c8\"]",
        "predecessor": "0x0000000000000000000000000000000000000000000000000000000000000000",
        "salt": "0x4dc1f751f0d410a7004e7b3b3e3f15481532b5f73d7c694cdfcf3351eec42c27"
      }
    }
  ]
}

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.54%. Comparing base (975e3c0) to head (5ec8703).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2372   +/-   ##
=======================================
  Coverage   51.54%   51.54%           
=======================================
  Files          91       91           
  Lines        4414     4414           
  Branches     1162     1162           
=======================================
  Hits         2275     2275           
  Misses       2136     2136           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36 naddison36 added the deployment Deploying smart contract label Jan 29, 2025
sparrowDom
sparrowDom previously approved these changes Jan 29, 2025
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shahthepro
shahthepro previously approved these changes Jan 29, 2025
@naddison36 naddison36 dismissed stale reviews from shahthepro and sparrowDom via 726189d January 29, 2025 22:34
@naddison36 naddison36 merged commit 477e67e into master Jan 30, 2025
11 of 17 checks passed
@naddison36 naddison36 deleted the nicka/deploy_005_sonic branch January 30, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Deploying smart contract
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants