-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sonic chain #2332
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
DanielVF,
naddison36,
shahthepro and
clement-ux
as code owners
December 20, 2024 15:07
shahthepro
reviewed
Dec 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2332 +/- ##
==========================================
+ Coverage 53.49% 54.18% +0.68%
==========================================
Files 80 80
Lines 4101 4101
Branches 1079 1079
==========================================
+ Hits 2194 2222 +28
+ Misses 1904 1876 -28
Partials 3 3 ☔ View full report in Codecov by Sentry. |
closing as we are now using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Sonic chain
Current issues:
DEBUG=hardhat-tracer:* TRACE=true yarn run node
contracts/node.sh
add--verbose
parameter to line 64 just afterhardhat node
(hardhat node --verbose
)this is the error hardhat reports
Relevant error trace:
and these are the logs from the tracer:
it seems to fail on this line within the tracer
To me it looks like
hardhat
plugin has issues setting up network tracing provider and thehardhat-tracer
can not attack to it.hardhat
but then we quickly get theeip-4895
error which prevents us from running the sonic chain