Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sonic chain #2332

Closed
wants to merge 9 commits into from
Closed

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Dec 20, 2024

Add support for Sonic chain

Current issues:

  • hardhat tracer not working
    • in console run DEBUG=hardhat-tracer:* TRACE=true yarn run node
    • in contracts/node.sh add --verbose parameter to line 64 just after hardhat node (hardhat node --verbose)
      this is the error hardhat reports
      Screenshot 2024-12-27 at 15 48 52
      Relevant error trace:

and these are the logs from the tracer:
Screenshot 2024-12-27 at 15 51 03
it seems to fail on this line within the tracer

To me it looks like hardhat plugin has issues setting up network tracing provider and the hardhat-tracer can not attack to it.

  • I've tried lowering the version of hardhat but then we quickly get the eip-4895 error which prevents us from running the sonic chain
  • unit/fork tests failing
  • CI failing

contracts/hardhat.config.js Show resolved Hide resolved
contracts/hardhat.config.js Outdated Show resolved Hide resolved
contracts/package.json Outdated Show resolved Hide resolved
contracts/package.json Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.18%. Comparing base (881df3f) to head (51a3870).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2332      +/-   ##
==========================================
+ Coverage   53.49%   54.18%   +0.68%     
==========================================
  Files          80       80              
  Lines        4101     4101              
  Branches     1079     1079              
==========================================
+ Hits         2194     2222      +28     
+ Misses       1904     1876      -28     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naddison36
Copy link
Collaborator

closing as we are now using nicka/sonic

@naddison36 naddison36 closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants