Add random() order support #16964
Open
Add random() order support #16964
+40
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
reviewed
Nov 7, 2024
| var id = idList.ChildNodes[i].ChildNodes[0]; | ||
|
|
||
| // RANDOM() is a special case where we need to use the dialect's random function. | ||
| if (id.ChildNodes[0].Token?.ValueString == "RANDOM") |
There was a problem hiding this comment.
This could work in SQLite & Postgres only, RAND is the one that works in SQL Server and MySQL
There was a problem hiding this comment.
_builder.Append(_dialect.RandomOrderByClause);
But maybe you forgot how sql queries are managed in this feature. Call me if you want a quick refresher.
There was a problem hiding this comment.
I revisited YesSQL and after I looked to _dialect.RandomOrderByClause it's fine for me
hishamco
approved these changes
Nov 7, 2024
| if (funArgs.Term.Name == "funArgs" && funArgs.ChildNodes.Count == 0) | ||
| { | ||
| _builder.Append(_dialect.RandomOrderByClause); | ||
| continue; |
There was a problem hiding this comment.
Suggested change
| continue; | |
| continue; |
Comment on lines
+254
to
+256
| var result = SqlParser.TryParse(sql, _schema, _defaultDialect, _defaultTablePrefix, null, out var rawQuery, out var errors); | ||
| Assert.True(result); | ||
| Assert.Equal(expectedSql, FormatSql(rawQuery)); |
There was a problem hiding this comment.
Suggested change
| var result = SqlParser.TryParse(sql, _schema, _defaultDialect, _defaultTablePrefix, null, out var rawQuery, out var errors); | |
| Assert.True(result); | |
| Assert.Equal(expectedSql, FormatSql(rawQuery)); | |
| // Arrange & Act | |
| var result = SqlParser.TryParse(sql, _schema, _defaultDialect, _defaultTablePrefix, null, out var rawQuery, out var errors); | |
| // Assert | |
| Assert.True(result); | |
| Assert.Equal(expectedSql, FormatSql(rawQuery)); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16961