Template content validation #16944
Merged
Template content validation #16944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamco
requested changes
Nov 2, 2024
src/OrchardCore.Modules/OrchardCore.Templates/Controllers/TemplateController.cs
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Templates/Controllers/TemplateController.cs
Outdated
Show resolved
Hide resolved
…lateController.cs Co-authored-by: Hisham Bin Ateya <[email protected]>
…on and controller name.
hishamco
approved these changes
Nov 2, 2024
|
Can this be merged, or are you waiting for anything, @hishamco? If it can, please merge. |
|
Modules should not reference modules. To remove the dependency use a route name. And if the module/feature is not enabled it could create an issue, so maybe check it first. Or just point to the documentation. |
|
Oops, I didn't notice that because the path did not contain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16943