Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added IsNew and TypePartDefinition to viewmodel #16898

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

brunoAltinet
Copy link
Contributor

@brunoAltinet brunoAltinet commented Oct 17, 2024

Fixes #16886

Do note there's a precedence of passing TypePartDefintion in UserPickerFieldDisplayDriver. I realise these fields are not used, but it enables for developers to override and customize field behaviour inside shape events.

Copy link
Member

@Piedone Piedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See from #16886 (comment)

@Piedone
Copy link
Member

Piedone commented Oct 25, 2024

Wouldn't there be a context object to add IsNew instead, that would help your use case in a generic way? (So we don't have to keep to this pattern.)

@brunoAltinet
Copy link
Contributor Author

Hmm, i'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sealed TextFieldDisplayDriver in 2.0 makes upgrading difficult
3 participants