-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ScriptsMiddleware(#15629) #16876
base: main
Are you sure you want to change the base?
Replace ScriptsMiddleware(#15629) #16876
Conversation
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. If you like Orchard Core, please star our repo and join our community channels. |
@dotnet-policy-service agree |
@DonaldDWebster what's the problem you are trying to solve or fix? |
I am trying to replace the middleware for the facebook & liquid modules for performance as part of issue #15629 |
I linked the issues in the description check #16876 (comment) Please fix the build |
Click the "Ready for Review" button once your PR is ready fro review |
111ed78
to
34b0355
Compare
34b0355
to
37dd66a
Compare
I’ve made the necessary fix and pushed the changes. It seems the workflow now requires your approval before it can run. If you could kindly approve the workflow at your convenience, that would be great. Thank you for the help today. |
This pull request has merge conflicts. Please resolve those before requesting a review. |
Fixes #15629
What is your input on what else to change? Thank you for the help.