Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeploymentStepDriverBase & DeploymentStepFieldsDriverBase #16874

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Oct 12, 2024

  • Reduce the code boilerplate for both the deployment step driver & deployment step fields driver
  • No more magic strings for deployment steps shapes

@hishamco hishamco force-pushed the hishamco/deployment-step-driver branch from d0600f9 to 146778c Compare October 12, 2024 11:25
@hishamco hishamco changed the title Add DeploymentStepDriverBase Add DeploymentStepDriverBase & DeploymentStepFieldsDriverBase Oct 12, 2024
@MikeAlhayek
Copy link
Member

@hishamco I don't think this is a good idea and may add more things to learn for no added value.

@hishamco
Copy link
Member Author

why there's no value, most of the time lost in a typo in a shape name during the deployment, please keep this open for now and I might open another PR to avoid magic strings at least. Then we can have a choice to keep it or break it

@MikeAlhayek
Copy link
Member

Because it hide too much details and it's hard to understand what is happening with the code. The logic in drivers should be visible so have full control and full visibility on what the code does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants